Closed BenediktBurger closed 6 months ago
Attention: Patch coverage is 93.10345%
with 18 lines
in your changes are missing coverage. Please review.
Project coverage is 87.63%. Comparing base (
4cc7cca
) to head (549f628
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Working for a week in the lab.
Removes dependency on jsonrpc2-objects and jsonrpc2-pyclient. These two dependencies can be written in two small files, which enables us to support older versions of Python than the dependencies allow.
- Adds a small version of
RPCServer
for use in Python<3.9 instead of the version ofopenrpc
package. This self written version does not yet support fully openrpc creation of method description, therefore it is good to keep openrpc as a dependency for those python versions, where it is available.Closes #5
A few thoughts from skimming the PR:
requires-python = ">=3.9"
, so installation should not be possible on lower Python versions anyway. I guess you need py38, nevertheless?Thanks for your comments
* I would caution against supporting py37, as it has been EOL since last year. Py38 follows this year.
The idea was, to include pyleco into pymodaq, which supports python 3.8 and @seb5g mentioned, that he would like to use it on an old system, which only allows python 3.7. However, I noticed, that python 3.7 is not achievable in #61 , so I dropped that idea.
* The package metadata has `requires-python = ">=3.9"`, so installation should not be possible on lower Python versions anyway. I guess you need py38, nevertheless?
This PR is the first one of two, which adds objects. The second one (#64 ) with more changes, changes also that requirement.
* It's good that you restricted the self-written code to just use it when necessary, as it's easier to remove later, and reduce maintenance burden.
Especially as it is not as complete as the imported code.
RPCServer
for use in Python<3.9 instead of the version ofopenrpc
package. This self written version does not yet support fully openrpc creation of method description, therefore it is good to keep openrpc as a dependency for those python versions, where it is available.Closes #5