pymeasure / pyleco

Python implementation of the Laboratory Experiment COntrol (LECO) protocol
MIT License
9 stars 3 forks source link

Old python #64

Closed BenediktBurger closed 6 months ago

BenediktBurger commented 6 months ago

Allow Python 3.8 (previously only Python>=3.9)

Main changes:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.65%. Comparing base (d337a29) to head (b5f29d6).

Files Patch % Lines
pyleco/directors/transparent_director.py 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================== + Coverage 87.63% 87.65% +0.02% ========================================== Files 36 36 Lines 2846 2859 +13 Branches 343 346 +3 ========================================== + Hits 2494 2506 +12 Misses 293 293 - Partials 59 60 +1 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/64/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/64/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `87.65% <84.21%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BenediktBurger commented 6 months ago

It worked for a week in the lab.