pymeasure / pyleco

Python implementation of the Laboratory Experiment COntrol (LECO) protocol
MIT License
9 stars 3 forks source link

Fix Coordinator to not use period in hostname as namespace #69

Closed BenediktBurger closed 5 months ago

BenediktBurger commented 5 months ago

Coordinator did turn the full hostname (including periods, for example "hostname.domain.tld") into the namespace. A namespace must not contain periods. This PR adds tests (which failed even where gethostname returns just the last name) and a fix covered by these tests.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.60%. Comparing base (646ccfd) to head (6867ff6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #69 +/- ## ======================================= Coverage 87.60% 87.60% ======================================= Files 36 36 Lines 2888 2888 Branches 348 348 ======================================= Hits 2530 2530 Misses 298 298 Partials 60 60 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/69/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `87.60% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.