pymeasure / pyleco

Python implementation of the Laboratory Experiment COntrol (LECO) protocol
MIT License
9 stars 3 forks source link

Expand test coverage #81

Closed BenediktBurger closed 5 months ago

BenediktBurger commented 5 months ago

Somehow the proxy_server test does hang

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.04%. Comparing base (5235b4d) to head (a09506c). Report is 4 commits behind head on main.

Files Patch % Lines
pyleco/management/starter.py 50.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================== + Coverage 87.59% 89.04% +1.44% ========================================== Files 36 36 Lines 2903 2902 -1 Branches 355 355 ========================================== + Hits 2543 2584 +41 + Misses 300 267 -33 + Partials 60 51 -9 ``` | [Flag](https://app.codecov.io/gh/pymeasure/pyleco/pull/81/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pymeasure/pyleco/pull/81/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure) | `89.04% <50.00%> (+1.44%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymeasure#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BenediktBurger commented 5 months ago

The tests fail due to some obscure bug in setuptools_scm version recovery, see https://github.com/pypa/setuptools_scm/issues/1038

Bump therefore setuptools requirement.

BenediktBurger commented 5 months ago

The tests fail due to some obscure bug in setuptools_scm version recovery, see pypa/setuptools_scm#1038

Bump therefore setuptools requirement.

Does not work as expected, now even more runners fail 🤦