pymedusa / Medusa

Automatic Video Library Manager for TV Shows. It watches for new episodes of your favorite shows, and when they are posted it does its magic.
https://pymedusa.com
GNU General Public License v3.0
1.79k stars 276 forks source link

DVD Order missing episodes #10173

Open ItsOnlyBinary opened 2 years ago

ItsOnlyBinary commented 2 years ago

Describe the bug

Some shows on tvdb have different episodes for the dvd order. Medusa seems to have issues adding these episodes.

Its seems its trying to add the episodes that are in DVD Order/Unassigned

https://www.thetvdb.com/series/the-good-place/seasons/dvd/1

Unassigned DVD Order episdoes

Name    Aired 
Everything Is Great!    2017-09-20  
Everything Is Bonzer!   2018-09-27  
Whenever You're Ready (1)   2020-01-30  
Whenever You're Ready (2)   2020-01-30

To Reproduce

Expected behavior expect each season to have 13 episodes that match the info on tvdb website

Medusa (please complete the following information):

Debug logs (at least 50 lines): General > Advanced Settings > Enable debug

``` 2021-12-17 17:29:27 WARNING APIv2-Thread_4 :: [] Config patch ignored {'subtitles': {'enabled': None}, 'subtitlesMulti': None} 2021-12-17 17:30:01 INFO APIv2-Thread_3 :: [] Updating scene exceptions... 2021-12-17 17:30:01 INFO APIv2-Thread_3 :: [] Updating exception_cache and exception_season_cache 2021-12-17 17:30:01 INFO APIv2-Thread_3 :: [] Finished processing 3808 scene exceptions. 2021-12-17 17:30:01 INFO APIv2-Thread_3 :: [] Building internal name cache for The Good Place 2021-12-17 17:30:10 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 2, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:10 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 3, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:15 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 2, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:15 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 3, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] 311711: Replacing images for show The Good Place 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Removed banner for series The Good Place 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Removed poster for series The Good Place 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Removed banner_thumb for series The Good Place 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Removed poster_thumb for series The Good Place 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Removed fanart for series The Good Place 2021-12-17 17:30:17 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 2, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:17 WARNING SHOWQUEUE-UPDATE :: [] No DVD order available for episode (season: 3, episode: 1). Skipping this episode. If you want to have this episode visible, please change it on the TheTVDB site, or consider disabling DVD order for the show: The Good Place(311711) 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Selected fanart for series 311711 (score=3.479069954525544, score_bay=5.958139909051088, rating=8, votes=8, res=1920x1080): https://www.thetvdb.com/banners/fanart/original/311711-10.jpg 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Selected poster for series 311711 (score=4.809388999020867, score_bay=8.618777998041734, rating=12, votes=12, res=680x1000): https://www.thetvdb.com/banners/posters/311711-3.jpg 2021-12-17 17:30:17 INFO SHOWQUEUE-UPDATE :: [] Cache check completed 2021-12-17 17:30:19 INFO SHOWQUEUE-REFRESH :: [] 311711: Performing refresh on The Good Place 2021-12-17 17:30:19 INFO SHOWQUEUE-REFRESH :: [] Trying to clean any empty folder under /mnt/tv/Archive/The Good Place (2016) 2021-12-17 17:30:19 INFO SHOWQUEUE-REFRESH :: [] 311711: Updating NFOs for show with new indexer info 2021-12-17 17:30:19 INFO SHOWQUEUE-REFRESH :: [] Cache check completed ```

Additional context Add any other context about the problem here.

p0psicles commented 2 years ago

Those episodes don't have a dvd_season and dvd_episode number assigned. If it's fixed on tvdb, it will show in medusa. We support 100% on the data that's provided through the api.

ItsOnlyBinary commented 2 years ago

I think youre maybe misunderstanding, those episodes do not have a dvd season/episode, but there are others that replace them that do not show in medusa

compare: https://www.thetvdb.com/series/the-good-place/seasons/dvd/2

to: image

Notice how S2 E1/E2 are missing from medusa

p0psicles commented 2 years ago

But those two episodes don't pop up in the api result with a dvd season / episode number. So how am I supposed to know those episodes should be used?

ItsOnlyBinary commented 2 years ago

I have been trying to figure out the v2 api so i could test that without much luck, I was worried that would be why they are not showing :(

Guess its their way of trying to force updating to v4 api with no free tier :(

Thanks for looking into it

Maybe time to start to look for an alternative, as it seems v2 will be completely ending early 2022. (originally planned early 2021)

p0psicles commented 2 years ago

yeah we have tvmaze and tmdb. And i'll look into adding support for alternative orders for those.