p0psicles
commented
4 years ago Doesn't thetvdb have the absolute numbering filled?
Open skarekrow opened 4 years ago
p0psicles
commented
4 years ago Doesn't thetvdb have the absolute numbering filled?
skarekrow
commented
4 years ago It seems not too. But reading https://github.com/pymedusa/Medusa/issues/5570, which seemed related, removing the show and all files, and adding it as a scene numbered show does indeed fill the absolute fields:
skarekrow
commented
4 years ago skarekrow
commented
4 years ago To make this more interesting, that workaround didn't fix this show: http://dereferer.org/?https://www.thetvdb.com/dereferrer/series/369801, which still has the problem despite being nuked and readded as a scene show.
I believe this issue is TVDB's fault, but not being able to manually add absolute numbers if they're missing is the bigger problem. That would let me workaround TVDB atm.
p0psicles
commented
4 years ago No, we depend on thetvdb in this case. It has worked for countless of shows. If the episodes are correctly added on tvdb everything works fine.
skarekrow
commented
4 years ago But surely even if that field is empty we should be able to update it? Otherwise it’s not terribly useful outside of the absolute numbers being wrong.
On Thu, Dec 19, 2019, at 1:07 AM, p0ps wrote:
No, we depend on thetvdb in this case. It has worked for countless of shows. If the episodes are correctly added on tvdb everything works fine.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pymedusa/Medusa/issues/7509?email_source=notifications&email_token=AAMD6N4ZTECX36GK23ISDW3QZMMTNA5CNFSM4J4SQHRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHIUY5Y#issuecomment-567364727, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMD6N7I6BZ2L2S4ENHOURLQZMMTNANCNFSM4J4SQHRA.
p0psicles
commented
4 years ago Yeah you have a point there. I know it should be improved. But right now to update scene absolute Medusa's api requires you to provide the indexers absolute. So your allowed the set a different scene absolute value.
We make a distinction of what's from indexer and what can be manually configured. If something is updated on indexer Medusa is also updated.
The absolute numbering is just like the title of an episode or the episode number or the synopsis. It would also be nice to override those, but that's currently not possible. If you want that you can request for a feature. Or do a pull request yourself.
It does depend on a proper tvdb configuration.
skarekrow
commented
4 years ago I didn’t think about having to synchronize backwards from future tvdb changes later on. That certainly would complicate things. I may have time to figure out a pr but it’s sounding like this really is better solved upstream proper. Or through xem? I’ve sent some show updates in the past but they haven’t been merged. Not sure how active the project is anymore outside the main contributor.
On Thu, Dec 19, 2019, at 4:28 AM, p0ps wrote:
Yeah you have a point there. I know it should be improved. But right now to update scene absolute Medusa's api requires you to provide the indexers absolute. So your allowed the set a different scene absolute value.
We make a distinction of what's from indexer and what can be manually configured. If something is updated on indexer Medusa is also updated.
The absolute numbering is just like the title of an episode or the episode number or the synopsis. It would also be nice to override those, but that's currently not possible. If you want that you can request for a feature. Or do a pull request yourself.
It does depend on a proper tvdb configuration.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pymedusa/Medusa/issues/7509?email_source=notifications&email_token=AAMD6N247ULFJNHDJBZQHQLQZNEF3A5CNFSM4J4SQHRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHJFC5I#issuecomment-567431541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMD6N3LRIYXGS5VXPQ4XHTQZNEF3ANCNFSM4J4SQHRA.
Describe the bug When a show does not have an scene absolute number and instead has an empty one, you're unable to edit the scene absolute number. Any attempt is met with an 'Update failed' message, with nothing in the logs.
I suspect this is because the column is empty to begin with instead of already having a number populating it.
What happens is medusa then tries to search for this with two zeros instead of just a show name, and that causes episodes to not be fetchable.
I've seen this on a few shows, so I'll use one as an example here
To Reproduce Steps to reproduce the behavior: Show I used to reproduce: Days of Urashimasakatasen (scene numbering is on)
Expected behavior That the scene absolute number would be changed and the show wouldn't search with 00 in the name anymore.
Screenshots
Medusa (please complete the following information): OS: debian x64/docker Branch: master on tag Version: 0.3.9 Commit: unknown Python version: 3.7.5 Database version: 44.14
Debug logs searching for an episode missing an absolute scene number(note the 00 in the title instead, causing 0 results):