search

pymedusa / Medusa

Automatic Video Library Manager for TV Shows. It watches for new episodes of your favorite shows, and when they are posted it does its magic.
https://pymedusa.com
GNU General Public License v3.0
1.79k stars 276 forks source link

Seed ratio improperly working #8555

Closed neo-neo1 closed 2 years ago

neo-neo1 commented 4 years ago

Describe the bug For all torrent search providers, setting a 0 (or 0.0) seed ratio does not set anything at all as if the option was left blank on the torrent client (Deluge daemon). 0.1 to 0.9 works properly but not 0 (or 0.0)

I just transferred over from SickChill where this was not a problem.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Search Providers'
  2. Click on 'Provider Options'
  3. Scroll down to 'Seed Ration'
  4. Set to 0 (or 0.0)

Expected behavior A seed ratio of 0.0 to be set in the torrent client (Deluge daemon) when a torrent is snatched. With a 0.0 seed ratio the torrent client does not seed at all and stops the torrent after download is complete.

Medusa

Entixs commented 4 years ago

what are you trying to do with seed ratio 0.0? Do you want them to seed forever or not?

neo-neo1 commented 4 years ago

what are you trying to do with seed ratio 0.0? Do you want them to seed forever or not?

To seed forever you use -1. I need a seed ratio of 0.0 for a specific tracker, commonly known as "leech". Instead of Medusa setting the seed ratio as 0 (or 0.0) it simply does not set anything at all as if the option was left blank, which by default the torrent client seeds forever. Works fine in SickChill.

With a 0.0 seed ratio the torrent client does not seed at all and stops the torrent after download is complete.

Entixs commented 4 years ago

I know this is probably a bug but can't you simply do that on your torrent client as well? Set a ratio setting for that specific tracker to stop seeding right after it's done downloading?

neo-neo1 commented 4 years ago

I know this is probably a bug but can't you simply do that on your torrent client as well? Set a ratio setting for that specific tracker to stop seeding right after it's done downloading?

I don't know of any torrent client that offers per-tracker seed ratio settings. Even if possible, I prefer for Medusa to handle this as its a given option that is supposed to work. Again, I used this feature in SickChill without issues and would love if Medusa was also able to properly parse 0. Thank for following up

p0psicles commented 2 years ago

I can create a branch with a change, would you be willing testing this out?