Open XxUnkn0wnxX opened 2 years ago
download handler needs to stop at Failed unpacking archive or hits a CRC error during unpacking <-- Fail the download & grab new download.
But the download handler doesn't unpack the files right? So I think this isn't an option.
But then sab should notice it couldn't unpack the archive. So can you see an error state in sab for this download? Maybe we can use sab's api to flag this download as failed?
I think the ffmpeg alternative could be a solution. But we could use knowit for this purpose. I can look into that.
Ow never mind, I see that medusa unpacked the file and got a crc. I'll have to dive in to see what checks we can apply here safely.
@XxUnkn0wnxX is this still an issue?
Describe the bug The bug is hard to diagnose, however to my knowledge medusa's built-in download handler has been processing incomplete Newsnab downloads, the issue occurs when either grabbing a nzb when it's still propagating or SABNzb leaves incomplete downloads with 50-80+ rar's with a partially unpacked video file
To Reproduce Very hard to reproduce, if you have a corrupted nzb that has the rar's and partially unpacked video file you can call Downloadhandler to manuly PP & results will be the same however to reproduce via a DL trigger its hit N miss as you do not know if the download will be corrupted or not.
Expected behavior download handler needs to stop at
Failed unpacking archive
or hits aCRC error during unpacking
<-- Fail the download & grab new download. also, add in checks like if the video file is smaller than it should be or run ffmpeg probe to check for video file corruption.Screenshots <-- at least add in check that checks snatch size vs downloaded size can round off by few MB. but 3G to 450mb should be detected as a problem..
Medusa (please complete the following information):
Debug logs (at least 50 lines): General > Advanced Settings > Enable debug
Full Log:
application copy.log