pymeng88 / wagic

Automatically exported from code.google.com/p/wagic
Other
0 stars 0 forks source link

Angelic Chorus (hardcoded) adds base toughness instead of actual toughness #277

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have Angelic Chorus and a card that pumps 
toughness (e.g. Gaea's Anthem) in play
2. Cast a creature (e.g. Grizzly Bears)

Expected output: Angelic Chorus gives 3 life 
(because the Grizzly Bears' toughness is 3 when it 
comes into play, due to the continuous effect of 
Gaea's Anthem. See rule 611.3c)

Instead: Angelic Chorus gives 2 life

Note: Angelic Chorus is currently hardcoded. I 
tried to softcode it with this rule:
auto=@movedto(creature|myBattlefield):life:t

...but this didn't work, probably because the 
target that triggers the action isn't passed to the 
action, and so WParsedInt doesn't know which cards' 
toughness it should calculate.

Nevertheless it might be better to softcode the 
card and fix it while doing so, instead of fixing 
it in the hardcode now and trying to softcode it 
later.

Original issue reported on code.google.com by Psyyri...@gmail.com on 28 Dec 2009 at 11:27

GoogleCodeExporter commented 9 years ago
About this matter, I'd like to add what has happened to me right now:

- Had 157 life points.
- Had 2 Angelic Chorus on play plus a Honor of the Pure (+1/+1 to all White 
Creatures
you control).
- I summon a Baneslayer Angel (3WW, Angel, 5/5 Flying, First Strike, Lifelink,
Protection from Dragons, Protection from Demons).

Ok, after it comes to play, I see myself with 168 life points. It's as if one 
of the
Angelic Chorus got the basic toughness value and then the second Angelic Chorus 
got
the increased value.

Did again before posting this and again, the life value gain was 11 life points,
instead of 10 or 11.

Original comment by azurhial...@gmail.com on 31 Dec 2009 at 6:47

GoogleCodeExporter commented 9 years ago
I'd like to add that I kept on playing, now with more than one Honor of the 
Pure, and
summoning the Angels from the Sigil of the Empty Throne (I think it was that 
card,
the one you summon a 4/4 Flying Angel token when you put an enchantment into 
play),
and the total life gain per Angel was 9 life points, regardless of how many 
Chori I
had in play (had only 2, the 2 from my deck).

Original comment by azurhial...@gmail.com on 31 Dec 2009 at 7:05

GoogleCodeExporter commented 9 years ago
That's a very tricky issue, not related to the fact that angelic chorus is 
hardcoded.

This is a problem with the order in which events happen when the creature comes 
into
play.

Currently angelic chorus is coded as a "listmaintainer ability", which is 
probably
wrong (it should be a triggered ability, but those didn't really exist when the 
card
was created).
It basically means its effects happen depending on when the card (angelic 
chorus) was
put into play.
This is also the case for honor of the pure (which is normal).

So, if you play, in that order:
1) Honor of the pure
2) Angelic chorus
3) Honor of the pure

Then a creature comes into play, the abilities will take effect in the same 
order:
1) the creature gets +1/+1
2) Angelic chorus gives you life
3) The creature gets +1/+1

Now, the Angelic chorus could be converted into a triggered ability, but I 
believe
that doesn't help because in Wagic, Triggered abilities happen before continuous
effects...

Original comment by wagic.the.homebrew@gmail.com on 7 Jan 2010 at 12:25

GoogleCodeExporter commented 9 years ago
Issue 417 has been merged into this issue.

Original comment by wagic.the.homebrew@gmail.com on 8 Jun 2010 at 8:05

GoogleCodeExporter commented 9 years ago
Fixed in rev2922.

Original comment by dan.solo...@googlemail.com on 21 Jan 2011 at 10:33