Closed fdrgsp closed 1 year ago
Base: 82.27% // Head: 83.02% // Increases project coverage by +0.75%
:tada:
Coverage data is based on head (
3890b48
) compared to base (ce156cd
). Patch coverage: 95.85% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@fdrgsp ... it seems like you saw https://github.com/fdrgsp/napari-micromanager/pull/33 ... but didn't merge it. how come?
can you change all of those strings to MDI6.___
and remove the getattr call, as in my PR?
@fdrgsp ... it seems like you saw fdrgsp#33 ... but didn't merge it. how come?
I looked at it on the phone and deleted the email and I didn't find it anymore :joy: I thought you added it in this PR and did't realize it was on mine, sorry
@tlambert03 do you like that when we add the widgets they are already docked? What about docking only the mda and explorer and leave the other undocked when created?
yeah, I do like it, for everything but the property browser... but lets handle special casing in a followup pr
good stuff. i'm inclined to merge as is, and then do some refactoring later today. sound good?
sounds great!!!
This PR replaces the menu with a
QToolBar
.Some of the
pymmcore-widgets
are now directly added to theQToolBar
, other can be called withQPushButtons
added to the toolbar.The creation of the
QToolBar
and all theQPushButtons
/pymmcore-widgets
connections have been moved frommain_window.py
to a single file called_toolbar.py
.