pymmcore-plus / napari-micromanager

GUI interface between napari and micromanager powered by pymmcore-plus and pymmcore-widgets
https://pymmcore-plus.github.io/napari-micromanager/
BSD 3-Clause "New" or "Revised" License
61 stars 21 forks source link

fix: add fixes for new widgets #246

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

pins widgets to >0.3.0 and gets tests passing again.

Note @fdrgsp ... I'm just skipping the sample explorer tests here. Please fix those when you get a chance

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.35% // Head: 74.16% // Decreases project coverage by -10.19% :warning:

Coverage data is based on head (b2580cf) compared to base (63a12e2). Patch coverage: 59.25% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #246 +/- ## =========================================== - Coverage 84.35% 74.16% -10.19% =========================================== Files 16 16 Lines 901 871 -30 =========================================== - Hits 760 646 -114 - Misses 141 225 +84 ``` | [Impacted Files](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/napari\_micromanager/\_\_main\_\_.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX19tYWluX18ucHk=) | `100.00% <ø> (ø)` | | | [src/napari\_micromanager/\_saving.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX3NhdmluZy5weQ==) | `55.93% <ø> (-16.95%)` | :arrow_down: | | [src/napari\_micromanager/\_mda\_handler.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX21kYV9oYW5kbGVyLnB5) | `72.79% <52.17%> (-25.37%)` | :arrow_down: | | [...rc/napari\_micromanager/\_gui\_objects/\_mda\_widget.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX2d1aV9vYmplY3RzL19tZGFfd2lkZ2V0LnB5) | `88.67% <100.00%> (-2.40%)` | :arrow_down: | | [...cromanager/\_gui\_objects/\_sample\_explorer\_widget.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX2d1aV9vYmplY3RzL19zYW1wbGVfZXhwbG9yZXJfd2lkZ2V0LnB5) | `57.33% <100.00%> (-40.01%)` | :arrow_down: | | [...c/napari\_micromanager/\_gui\_objects/\_save\_widget.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX2d1aV9vYmplY3RzL19zYXZlX3dpZGdldC5weQ==) | `90.62% <100.00%> (ø)` | | | [src/napari\_micromanager/\_mda\_meta.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX21kYV9tZXRhLnB5) | `100.00% <100.00%> (ø)` | | | [...pari\_micromanager/\_gui\_objects/\_shutters\_widget.py](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL25hcGFyaV9taWNyb21hbmFnZXIvX2d1aV9vYmplY3RzL19zaHV0dGVyc193aWRnZXQucHk=) | `89.18% <0.00%> (-10.82%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/pymmcore-plus/napari-micromanager/pull/246?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ianhi commented 1 year ago

nice!