search

pymmcore-plus / napari-micromanager

GUI interface between napari and micromanager powered by pymmcore-plus and pymmcore-widgets
https://pymmcore-plus.github.io/napari-micromanager/
BSD 3-Clause "New" or "Revised" License
61 stars 21 forks source link

ci: fixing tests, drop py38 #336

Closed tlambert03 closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.24%. Comparing base (340b299) to head (cc843ab).

Files Patch % Lines
...napari_micromanager/_gui_objects/_stages_widget.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ========================================== + Coverage 78.20% 78.24% +0.03% ========================================== Files 13 13 Lines 624 625 +1 ========================================== + Hits 488 489 +1 Misses 136 136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 4 months ago

wow... amazingly, just importing pymmcore before importing any Qt backend ended up fixing stuff on here. 😱

opened an issue at pymmcore: https://github.com/micro-manager/pymmcore/issues/119

but tests are passing here again as long as we ensure that we import pymmcore first