search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

feat: update the CameraRoiWidget to handle multiple cameras #292

Closed fdrgsp closed 5 days ago

fdrgsp commented 7 months ago
Screenshot 2024-04-24 at 2 40 29 PM
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 93.26599% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (33c1350) to head (e62387c). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/control/_camera_roi_widget.py 93.26% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ========================================== - Coverage 90.73% 89.80% -0.94% ========================================== Files 85 85 Lines 9233 9377 +144 ========================================== + Hits 8378 8421 +43 - Misses 855 956 +101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

tlambert03 commented 1 month ago

hey @fdrgsp, is this still something we should get in? I haven't looked closely yet, but I'm wondering why support for two cameras would require a diff of 700+ lines. was this harder than it sounds?

fdrgsp commented 1 month ago

Hey @tlambert03 , I had to change the logic a bit to support the Multi Camera adapter so that each camera could be controlled individually. I also added a CameraInfo dataclass to store the info of each camera. I did it a while ago so I probably need to dig more into the code to exactly remember why the changes!