search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

feat: HCS Wizard Widget with useq WellPlatePlan #308

Closed fdrgsp closed 2 months ago

fdrgsp commented 4 months ago

This is a smaller version of #304 that already takes in consideration some of the suggestions and uses the new useq.WellPlatePlan.

Here we add the HCSWizard but at the moment we cannot update/modify the plate database (the widget is using a default one). In addition, the HCSWizard is not yet linked to the MDAWidget, it only output a useq.WellPlatePlan.

I think it is easier to start from this and add the database and MDAWidget link later on.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 85.68165% with 188 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (4c51583) to head (a09d93e).

Files Patch % Lines
.../pymmcore_widgets/hcs/_calibration_widget/_util.py 29.09% 39 Missing :warning:
...ets/hcs/_calibration_widget/_calibration_widget.py 80.00% 34 Missing :warning:
src/pymmcore_widgets/hcs/_graphics_items.py 72.32% 31 Missing :warning:
src/pymmcore_widgets/hcs/_plate_graphics_scene.py 63.29% 29 Missing :warning:
.../pymmcore_widgets/hcs/_main_wizard/_main_wizard.py 84.24% 23 Missing :warning:
...mmcore_widgets/hcs/_fov_widget/_fov_sub_widgets.py 92.55% 16 Missing :warning:
src/pymmcore_widgets/hcs/_plate_widget.py 92.30% 8 Missing :warning:
...rc/pymmcore_widgets/hcs/_fov_widget/_fov_widget.py 98.10% 3 Missing :warning:
src/pymmcore_widgets/hcs/_util.py 88.00% 3 Missing :warning:
...cs/_calibration_widget/_calibration_sub_widgets.py 99.39% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #308 +/- ## ========================================== - Coverage 90.06% 89.17% -0.89% ========================================== Files 71 84 +13 Lines 7919 9232 +1313 ========================================== + Hits 7132 8233 +1101 - Misses 787 999 +212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 4 months ago

coming along! I'm going to do some direct edits this morning and will make a PR to this branch, so hold off on making many changes for a little bit if possible :)

fdrgsp commented 4 months ago

ok @tlambert03 , I merged all the changes from #314 and fixed tests.

tlambert03 commented 4 months ago

great! Now have a look at #315 and merge that when ready

tlambert03 commented 2 months ago

superceded by #360