search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

fix: WellPlateWidget initial drawing #327

Closed fdrgsp closed 4 months ago

fdrgsp commented 4 months ago

currently if we create the WellPlateWidget without passing a plate arg, the plate is not drawn even if there is a plate selected in the combobox. This will fix that.

Screenshot 2024-07-12 at 9 51 09 PM Screenshot 2024-07-12 at 9 51 24 PM
tlambert03 commented 4 months ago

thanks, this is in #322 as well, let's use that implementation, which is a bit more direct:

https://github.com/pymmcore-plus/pymmcore-widgets/pull/322/files#diff-e61f82640f1bbe3e269fae5e5b541165750e64fb403b2ae4312cd7e96451c82aR117-R118

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.58%. Comparing base (426baf2) to head (4512092). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== - Coverage 90.58% 90.58% -0.01% ========================================== Files 74 74 Lines 8372 8371 -1 ========================================== - Hits 7584 7583 -1 Misses 788 788 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 4 months ago

scratch that... i like this one better