pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

[WIP] feat: new widget to manage Groups and Presets #338

Closed fdrgsp closed 1 month ago

fdrgsp commented 4 months ago

@tlambert03 I started from your nicel #307 PR and I've use the logic to create a new GroupPresetWidget. I believe it is easier to manage the Micro-Manager Groups and Presets (when compared to our current widget). I'm sure we can improve this but I think it is a good starting point.

https://github.com/user-attachments/assets/ded6229e-9923-4197-908d-e2666eb60537

TODO:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 20.40441% with 433 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (ae4a3dd) to head (fe5919a). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...idgets/group_preset_widget/_group_preset_dialog.py 12.21% 273 Missing :warning:
..._widgets/group_preset_widget/_properties_tables.py 21.30% 133 Missing :warning:
...idgets/device_properties/_device_property_table.py 50.90% 27 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #338 +/- ## ========================================== - Coverage 90.72% 86.76% -3.96% ========================================== Files 85 88 +3 Lines 9184 9712 +528 ========================================== + Hits 8332 8427 +95 - Misses 852 1285 +433 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 1 month ago

I'm going to close this since i think #307 will encompass all the use cases here