pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

style: unfill radio buttions in GridPlanWidget #344

Closed gselzer closed 4 months ago

gselzer commented 4 months ago

This PR, closing #339, adds a HACK to prevent the OS accent color from filling up the GridPlanWidget's radio buttons on Windows 11. This HACK seems to be the least-bad of the different options that could resolve the issue, which are:

@tlambert03 and/or @fdrgsp: I'd be happy for your opinions and/or testing. It looks nice to me on Windows 11, and on WSL (Wayland)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.59%. Comparing base (7ec66e5) to head (5b481c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #344 +/- ## ======================================= Coverage 90.59% 90.59% ======================================= Files 74 74 Lines 8379 8380 +1 ======================================= + Hits 7591 7592 +1 Misses 788 788 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gselzer commented 4 months ago

Closes #339