pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

feat: plate navigator for HCS calibration testing #356

Closed fdrgsp closed 3 months ago

fdrgsp commented 4 months ago

@tlambert03 what do you think to use something like this for the calibration testing of the HCS wizard? Basically the user has the freedom to click anywhere in the well to move to the stage...

https://github.com/user-attachments/assets/4c76fe7f-7333-4a23-864e-4708331a94b7

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.51095% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (112927f) to head (1d34c06). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ymmcore_widgets/useq_widgets/_well_plate_widget.py 84.84% 10 Missing :warning:
.../pymmcore_widgets/hcs/_plate_calibration_widget.py 95.77% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #356 +/- ## ========================================== - Coverage 90.85% 90.83% -0.03% ========================================== Files 77 77 Lines 8816 8938 +122 ========================================== + Hits 8010 8119 +109 - Misses 806 819 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 4 months ago

love it. we certainly need something like that. When you click does it always go to the center? something that some commercial software add is the ability to go to top/left/bot/right/center:

image

(or, in the corners for a square well). If you're trying to calibrate a plate, those would likely be more useful places to visit? of course, as the number of wells goes up, it would be hard to show all of those points

fdrgsp commented 4 months ago

When you click does it always go to the center?

At the moment, the stage goes wherever you click in the well (not always in the center). But we can make fixed position per well I guess!

tlambert03 commented 4 months ago

ah! i see, yeah that's cool too. i can imagine two different modes i guess. one where you likely want specific easily identifiable places, and the current one with complete freedom

fdrgsp commented 4 months ago

ah! i see, yeah that's cool too. i can imagine two different modes i guess. one where you likely want specific easily identifiable places, and the current one with complete freedom

hey @tlambert03 , what do you think about this?

https://github.com/user-attachments/assets/51e767a3-aae3-44c9-9a04-2a73eed487d4

tlambert03 commented 4 months ago

woah that's gorgeous

fdrgsp commented 3 months ago

@tlambert03 I think this widget is functioning as we want, when you have time can you have a look at the code?

Once this is merged, I can open a PR where we combine it with the PlateCalibrationWidget.