search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

feat: add HCSWizard to MDAWIdget #362

Closed fdrgsp closed 1 month ago

fdrgsp commented 1 month ago

this PR adds the HCSWizard to the MDAWidget.

Screenshot 2024-10-01 at 9 49 50 AM Screenshot 2024-10-02 at 10 26 56 AM
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 83.73984% with 20 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (ecabdf3) to head (84acb94). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/mda/_core_positions.py 80.39% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================== - Coverage 90.85% 90.74% -0.12% ========================================== Files 79 79 Lines 9102 9209 +107 ========================================== + Hits 8270 8357 +87 - Misses 832 852 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fdrgsp commented 1 month ago

hey @tlambert03, I think you can have another look!

tlambert03 commented 1 month ago

everything is looking good @fdrgsp, but i noticed that when you add positions from hcs (or go back to making them editable), the widget emits a lot of change events (i think it's around the number of positions in the well plate). I added a failing test that demonstrates this. Can you look into it?

fdrgsp commented 1 month ago

everything is looking good @fdrgsp, but i noticed that when you add positions from hcs (or go back to making them editable), the widget emits a lot of change events (i think it's around the number of positions in the well plate). I added a failing test that demonstrates this. Can you look into it?

@tlambert03 it should be fixed now.