search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

fix: fix splitting logic and deduplicate code in Groups Presets Widgets #365

Closed tlambert03 closed 1 month ago

tlambert03 commented 1 month ago

fixes #363

This is just a patch for the immediate issue, these widgets still contain a lot of duplicated code and possible bugs, and should be replaced (with one of #307, #320, #338, etc...)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.69%. Comparing base (7b074d3) to head (9a7c04a). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 90.74% 90.69% -0.05% ========================================== Files 79 80 +1 Lines 9209 9160 -49 ========================================== - Hits 8357 8308 -49 Misses 852 852 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.