search

pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

fix: fix include_z when setting stage positions value in PositionTable widget #381

Closed tlambert03 closed 3 weeks ago

tlambert03 commented 3 weeks ago

fixes #380

for now, this will set the "include z" checkbox to True if any of the positions have a Z position. If only some of them have a z position, it will emit a warning.

If we need the feature in the future, we could further elaborate to somehow let some rows have a Z position of None while others don't

tlambert03 commented 3 weeks ago

tests are failing, but i think it might be the assertion in the test itself that is no longer correct

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.72%. Comparing base (d58003b) to head (30371b3). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #381 +/- ## ======================================= Coverage 90.71% 90.72% ======================================= Files 85 85 Lines 9188 9197 +9 ======================================= + Hits 8335 8344 +9 Misses 853 853 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.