pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

feat: indicate pre-init properties in device property browser #382

Closed fdrgsp closed 2 weeks ago

fdrgsp commented 3 weeks ago

tests failing because of https://github.com/hgrecco/pint/issues/2074.

update for #375 .

@tlambert03 instead of using a specific icon as you mentioned in #375 , what about changing the background color as we do for the read only props?

Screenshot 2024-11-06 at 8 34 57 AM Screenshot 2024-11-06 at 8 35 17 AM

closes #375

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.70%. Comparing base (7277aa6) to head (cf6e723). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #382 +/- ## ======================================= Coverage 90.70% 90.70% ======================================= Files 85 85 Lines 9199 9199 ======================================= Hits 8344 8344 Misses 855 855 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 3 weeks ago

that works for me. did you happen to check how it looks on a dark theme?

fdrgsp commented 3 weeks ago

that works for me. did you happen to check how it looks on a dark theme?

maybe too light gray?

Screenshot 2024-11-06 at 9 00 20 AM
tlambert03 commented 3 weeks ago

oh well :) it's fine. we've got enough dark theme issues anyway. if we ever coordinate theming more generally we can address it then

tlambert03 commented 3 weeks ago

however, if you're inclined, you could look into using a https://doc.qt.io/qt-6/qpalette.html#ColorRole-enum (which would pull from the palette) instead of hard-coding a color

fdrgsp commented 3 weeks ago

however, if you're inclined, you could look into using a https://doc.qt.io/qt-6/qpalette.html#ColorRole-enum (which would pull from the palette) instead of hard-coding a color

This is using QPalette.Dark. I think it looks ok...

Screenshot 2024-11-06 at 11 43 45 AM Screenshot 2024-11-06 at 11 43 52 AM