Closed fdrgsp closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.70%. Comparing base (
7277aa6
) to head (cf6e723
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
that works for me. did you happen to check how it looks on a dark theme?
that works for me. did you happen to check how it looks on a dark theme?
maybe too light gray?
oh well :) it's fine. we've got enough dark theme issues anyway. if we ever coordinate theming more generally we can address it then
however, if you're inclined, you could look into using a https://doc.qt.io/qt-6/qpalette.html#ColorRole-enum (which would pull from the palette) instead of hard-coding a color
however, if you're inclined, you could look into using a https://doc.qt.io/qt-6/qpalette.html#ColorRole-enum (which would pull from the palette) instead of hard-coding a color
This is using QPalette.Dark. I think it looks ok...
tests failing because of https://github.com/hgrecco/pint/issues/2074.
update for #375 .
@tlambert03 instead of using a specific icon as you mentioned in #375 , what about changing the background color as we do for the read only props?
closes #375