pymmcore-plus / pymmcore-widgets

A set of Qt-based widgets onto the pymmcore-plus model
https://pymmcore-plus.github.io/pymmcore-widgets
Other
12 stars 7 forks source link

fix: disable autofocus axis widget if no autofocus device is loaded/selected #386

Closed fdrgsp closed 6 days ago

fdrgsp commented 2 weeks ago

This PR updates the logic for when the autofocus devices (Autofocus Axis widget and Autofocus Per Position checkbox)should be disabled to then emit a correct useq.MDASequence.

On top of disabling them when an absolute z plan is selected, this PR adds:

Screenshot 2024-11-11 at 6 10 51 PM 1
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 98.82353% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (1cda2b7) to head (00e3a44). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/pymmcore_widgets/mda/_core_mda.py 97.77% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #386 +/- ## ========================================== - Coverage 90.71% 90.67% -0.05% ========================================== Files 85 85 Lines 9234 9290 +56 ========================================== + Hits 8377 8424 +47 - Misses 857 866 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: