search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

refactor: move replace to FrozenModel #104

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

this moves the replace method to the frozen base model, and removes the kwargs from the signature

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (a904ae3) 96.34% compared to head (329d1a4) 96.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #104 +/- ## ========================================== - Coverage 96.34% 96.33% -0.01% ========================================== Files 12 12 Lines 738 736 -2 ========================================== - Hits 711 709 -2 Misses 27 27 ``` | [Impacted Files](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_base\_model.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2Jhc2VfbW9kZWwucHk=) | `88.31% <100.00%> (+0.47%)` | :arrow_up: | | [src/useq/\_mda\_sequence.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/104?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `98.34% <100.00%> (-0.04%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.