search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

refactor: move pycromanager stuff to new module, update docs a bit #118

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

This PR moves all pycromanager-specific logic to useq.pycromanager and deprecates directly using to_pycromanager as a method from MDASequence or MDAEvent. It also updates documentation slightly

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 85.00% and project coverage change: -0.56% :warning:

Comparison is base (29c1fa7) 96.94% compared to head (292754f) 96.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== - Coverage 96.94% 96.39% -0.56% ========================================== Files 13 14 +1 Lines 786 804 +18 ========================================== + Hits 762 775 +13 - Misses 24 29 +5 ``` | [Files Changed](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_mda\_event.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9ldmVudC5weQ==) | `78.26% <25.00%> (-7.46%)` | :arrow_down: | | [src/useq/pycromanager.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvcHljcm9tYW5hZ2VyLnB5) | `88.00% <88.00%> (ø)` | | | [src/useq/\_mda\_sequence.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `98.34% <100.00%> (+0.04%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.