search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

fix: valueError also if no fov in GridWidthHeight #142

Closed fdrgsp closed 9 months ago

fdrgsp commented 9 months ago

This PR raise valueError when calling num_positions() also in case a GridWidthHeight is set without fov_width and fov_height.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a269e66) 98.28% compared to head (25a727d) 97.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================== - Coverage 98.28% 97.03% -1.26% ========================================== Files 14 14 Lines 877 877 ========================================== - Hits 862 851 -11 - Misses 15 26 +11 ``` | [Files](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_grid.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2dyaWQucHk=) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/142/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.