pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

feat: make af-device name optional #145

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

closes #141 by allowing both autofocus device name and offset to be None. If name is not provided, engines are allowed to simply "apply the offset" as best fits the current hardware (usually, there is only one way to do it at any given time anyway). If offset is None, then the presence of a Hardware Autofocus event simply means "turn on the autofocus without worrying about offset".

see related https://github.com/pymmcore-plus/pymmcore-plus/pull/270

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (17e6533) 98.28% compared to head (da4c3a6) 98.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #145 +/- ## ======================================= Coverage 98.28% 98.28% ======================================= Files 14 14 Lines 877 877 ======================================= Hits 862 862 Misses 15 15 ``` | [Files](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_actions.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2FjdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | | | [src/useq/\_hardware\_autofocus.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2hhcmR3YXJlX2F1dG9mb2N1cy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.