search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

[WIP] Fix: update time interval exceeded boolean #147

Open fdrgsp opened 1 year ago

fdrgsp commented 1 year ago

currently, interval=0 will pretty much always give you time_interval_exceeded = True

I think that in the case of a time_plan with interval=0, the time_interval_exceeded boolean should change depending on the sequence axis_order.

if axis_order="tpc", time_interval_exceeded=True if axis_order="ptc", time_interval_exceeded=False

because...

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.69%. Comparing base (c024a68) to head (613b5d3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== + Coverage 95.65% 95.69% +0.04% ========================================== Files 15 15 Lines 1058 1069 +11 ========================================== + Hits 1012 1023 +11 Misses 46 46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.