Closed tlambert03 closed 3 months ago
@fdrgsp, I touched this up a bit. ~It still needs well_points_plan
to be implemented~ ... (added)
@fdrgsp, I just added a way to register plates: useq.register_well_plates()
it takes either kwargs, or a mapping, and values can either be a dict, or a WellPlate instance
useq.register_well_plates(
{
"silly": useq.WellPlate(
rows=1, columns=1, well_spacing=1, circular_wells=False
)
},
myplate={"rows": 8, "columns": 8, "well_spacing": 9},
)
so pymmcore widgets could load a user database, and then register it with useq
Attention: Patch coverage is 82.66667%
with 39 lines
in your changes missing coverage. Please review.
Project coverage is 95.70%. Comparing base (
1657db7
) to head (7366f82
). Report is 10 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/useq/_plate.py | 81.73% | 38 Missing :warning: |
src/useq/_position.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
shall we merge it and improve in later PRs @fdrgsp?
shall we merge it and improve in later PRs @fdrgsp?
Yes, I think so. We can add the better position naming after (https://github.com/pymmcore-plus/useq-schema/pull/166#discussion_r1660311170).
I'm working on using this WellPlatePlan
in the HCS Wizard
and I'll open a new PR soon.
We can add the better position naming after (https://github.com/pymmcore-plus/useq-schema/pull/166#discussion_r1660311170).
yeah, and #169 was also partially with naming in mind (though it's probably not immediately obvious)