feat: few updates for WellPlatePlan

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.

https://pymmcore-plus.github.io/useq-schema/

BSD 3-Clause "New" or "Revised" License

14 stars 5 forks source link

feat: few updates for WellPlatePlan #171

Closed fdrgsp closed 2 weeks ago

fdrgsp commented 2 weeks ago

@tlambert03 these are few updates I think might be useful.

add name to GridPosition + update Position
make well_size required
add docstrings

I also added a test to check the serialization because I was getting something weird when working on the HCSWizard widget. Basically if you create a WellPlatePlan from a dict, the well_points_plan is always Position() no matter what you pass and I don't yet understand why...

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (1657db7) to head (abe759e). Report is 11 commits behind head on main.

Files	Patch %	Lines
src/useq/_plate.py	76.92%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #171 +/- ## ========================================== - Coverage 98.28% 95.71% -2.57% ========================================== Files 14 15 +1 Lines 874 1050 +176 ========================================== + Hits 859 1005 +146 - Misses 15 45 +30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.