search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

fix: fix units for correct WellPlatePlan iteration #172

Closed fdrgsp closed 2 weeks ago

fdrgsp commented 2 weeks ago

I think we needed to fix the unit of few methods of the WellPlatePlan since the well_points_plan and the stage coordinates are expressed in µm and the WellPlate in mm.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.54%. Comparing base (1657db7) to head (dd11d90). Report is 12 commits behind head on main.

Files Patch % Lines
src/useq/_plate.py 55.55% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## ========================================== - Coverage 98.28% 95.54% -2.74% ========================================== Files 14 15 +1 Lines 874 1056 +182 ========================================== + Hits 859 1009 +150 - Misses 15 47 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tlambert03 commented 2 weeks ago

good one, i think i'm gonna play around with using pint here in another PR... should help us avoid this stuff a bit