search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

fix: fix pydantic smart union in older versions, and add minreqs test #178

Closed tlambert03 closed 2 months ago

tlambert03 commented 2 months ago

found an issue with the smart union on MDASequnce.grid_plan: MultiPointPlan ... @fdrgsp, this may be related to the bug you were seeing ... but not sure. it was working only on pydantic 2.8+ this should fix back to 2.2, and adds a tests for that

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.90%. Comparing base (5801ee6) to head (f05dfb1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #178 +/- ## ======================================= Coverage 95.90% 95.90% ======================================= Files 16 16 Lines 1075 1075 ======================================= Hits 1031 1031 Misses 44 44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.