pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

refactor: rename tile to grid #76

Closed fdrgsp closed 1 year ago

fdrgsp commented 1 year ago

This PR changes the name of the tiles object in grid (e.g. TileFromCorners -> GridFromCorners)

merge after #75

tests are failing because of 0.34% difference.

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.46% // Head: 93.12% // Decreases project coverage by -0.34% :warning:

Coverage data is based on head (c316f56) compared to base (61a2333). Patch coverage: 95.13% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ========================================== - Coverage 93.46% 93.12% -0.34% ========================================== Files 10 10 Lines 551 582 +31 ========================================== + Hits 515 542 +27 - Misses 36 40 +4 ``` | [Impacted Files](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_grid.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2dyaWQucHk=) | `94.57% <94.57%> (ø)` | | | [src/useq/\_\_init\_\_.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/useq/\_mda\_sequence.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `92.61% <100.00%> (-2.72%)` | :arrow_down: | | [src/useq/\_position.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX3Bvc2l0aW9uLnB5) | `96.42% <100.00%> (-0.13%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.