pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

fix: update GridFromCorners with top, left, bottom, right floats #80

Closed fdrgsp closed 1 year ago

fdrgsp commented 1 year ago

This PR updates the GridFromCorners object. Instead of setting up the grid bounding box using 2 coordinates (corner1 and corner2), the grid is now defined by top, left, bottom, right floats.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.49% // Head: 94.42% // Decreases project coverage by -0.07% :warning:

Coverage data is based on head (f7c2d46) compared to base (06ec82b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #80 +/- ## ========================================== - Coverage 94.49% 94.42% -0.07% ========================================== Files 10 10 Lines 581 574 -7 ========================================== - Hits 549 542 -7 Misses 32 32 ``` | [Impacted Files](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_\_init\_\_.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [src/useq/\_grid.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2dyaWQucHk=) | `100.00% <100.00%> (ø)` | | | [src/useq/\_mda\_sequence.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `92.66% <100.00%> (ø)` | | | [src/useq/\_time.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX3RpbWUucHk=) | `100.00% <0.00%> (ø)` | | | [src/useq/\_base\_model.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2Jhc2VfbW9kZWwucHk=) | `87.50% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.