search

pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

fix: fix _check_order method #86

Closed fdrgsp closed 1 year ago

fdrgsp commented 1 year ago

This PR fixes an issue in the MDASequence _check_order methods. It prevents a grid_plan to be "validated" with the default for_size (1, 1) when not needed.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (10e485d) 96.11% compared to head (812470c) 96.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ======================================= Coverage 96.11% 96.11% ======================================= Files 10 10 Lines 617 617 ======================================= Hits 593 593 Misses 24 24 ``` | [Impacted Files](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_mda\_sequence.py](https://codecov.io/gh/pymmcore-plus/useq-schema/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `97.94% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.