pymmcore-plus / useq-schema

An implementation agnostic schema for describing a sequence of events during a multi-dimensional imaging acquisition.
https://pymmcore-plus.github.io/useq-schema/
BSD 3-Clause "New" or "Revised" License
15 stars 5 forks source link

refactor: Simplify subsequence #95

Closed tlambert03 closed 1 year ago

tlambert03 commented 1 year ago

This simplifies the logic in iter_sequence, which has gotten a little hairy

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.14% and project coverage change: +0.21 :tada:

Comparison is base (7486cf9) 96.11% compared to head (17258b3) 96.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #95 +/- ## ========================================== + Coverage 96.11% 96.33% +0.21% ========================================== Files 10 10 Lines 618 654 +36 ========================================== + Hits 594 630 +36 Misses 24 24 ``` | [Impacted Files](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus) | Coverage Δ | | |---|---|---| | [src/useq/\_mda\_event.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9ldmVudC5weQ==) | `86.79% <66.66%> (-3.01%)` | :arrow_down: | | [src/useq/\_mda\_sequence.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX21kYV9zZXF1ZW5jZS5weQ==) | `99.11% <98.95%> (+1.15%)` | :arrow_up: | | [src/useq/\_channel.py](https://app.codecov.io/gh/pymmcore-plus/useq-schema/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pymmcore-plus#diff-c3JjL3VzZXEvX2NoYW5uZWwucHk=) | `96.29% <100.00%> (+0.46%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.