In the constructor for ModbusSerialServer, the call to super().__init__ flipped the "request_tracer" and "response_manipulator" parameters. Passing a request_tracer as normal resulted in a "cannot unpack non-iterable NoneType object" error when a request was recieved.
To reproduce the same bug, replace the TCP server with a serial server in the server_hook.py example.
Fixed by reversing the two parameters in the function call. Also added labels to try and prevent further ordering issues if parameters are changed in the future.
In the constructor for
ModbusSerialServer, the call tosuper().__init__flipped the"request_tracer"and"response_manipulator"parameters. Passing arequest_traceras normal resulted in a"cannot unpack non-iterable NoneType object"error when a request was recieved.To reproduce the same bug, replace the TCP server with a serial server in the
server_hook.pyexample.Fixed by reversing the two parameters in the function call. Also added labels to try and prevent further ordering issues if parameters are changed in the future.