search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.29k stars 938 forks source link

Support aiohttp 3.9.0b1 #1886

Closed alexrudd2 closed 12 months ago

alexrudd2 commented 12 months ago

Thanks to @Dreamsorcerer in https://github.com/pymodbus-dev/pymodbus/issues/1883#issuecomment-1804196681

janiversen commented 12 months ago

I think we should wait !!

HA uses: aiohttp==3.9.0b0;python_version>='3.12' aiohttp==3.8.5;python_version<'3.12'

and that works fine, you pinned 3.9.0b0 so lets stay with that until they get a stable version.

Dreamsorcerer commented 12 months ago

HA is affected by a different regression (client-side), which we already have a fix for. The change in this PR is correct, for both current and previous versions of aiohttp (as shown in the docs).

Dreamsorcerer commented 12 months ago

Even in previous versions of aiohttp, you were never running the cleanup steps for the web app.