search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.22k stars 907 forks source link

Missing Copyright in License file #1908

Closed andresrinivasan closed 8 months ago

andresrinivasan commented 8 months ago
andresrinivasan commented 8 months ago

Just trying to be helpful. The license currently asks that the copyright be reproduced but there is no copyright at the moment.

janiversen commented 8 months ago

Help is always welcome, which is why I started by thanking for the PR.

I did not say that we would not merge your PR, only that I think it makes no legal difference.

However just marking 2023 indicates there was no copyright in 2022 and earlier years, which plain simple is wrong, which is why I asked for a change in the PR.

andresrinivasan commented 8 months ago

Ah, I didn't understand. You're asking that I update the PR to 2008-2023. Correct?

janiversen commented 8 months ago

yes