search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.26k stars 922 forks source link

Improve client types #1997

Closed alexrudd2 closed 7 months ago

alexrudd2 commented 7 months ago

The base connect method is an empty body that is intended to be over-ridden.* It implicitly has no return value. The concrete classes have a return value of bool.

Also, there is no reason to call async_execute without request, so it should not be set to None.

alexrudd2 commented 7 months ago

*it's probably best to use an Abstract Base Class for this, but some of the tests run directly against the base class instead of concrete ones.