search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

Improve types for REPL #2007

Closed alexrudd2 closed 4 months ago

alexrudd2 commented 4 months ago

Closes #2006

Also reduces a further 15 mypy errors and deletes some junk.

alexrudd2 commented 4 months ago

Is your problem solved ?

Not sure. I submitted this PR from my home machine (not at work), and was only looking at pyright output. I created the issue for the benefit of anyone else who may be searching the issue tracker. (They might run into it on a released version even if we have fixed in dev)

Today I have installed pymodbus (from pip not git) on a work machine, which led to #2008