REPL argument completions don't work

pymodbus-dev / pymodbus

A full modbus protocol written in python

Other

2.16k stars 891 forks source link

REPL argument completions don't work #2008

Closed alexrudd2 closed 4 months ago

alexrudd2 commented 4 months ago

File "/home/alex/.local/lib/python3.10/site-packages/pymodbus/repl/client/completer.py", line 133, in get_completions commands = list(command.get_completion())

Exception 'NoneType' object has no attribute 'get_completion' Press ENTER to continue...

Versions

Python: 3.10
OS: Ubuntu (WSL 2)
Pymodbus: 3.6.4
Modbus Hardware (if used):

Pymodbus Specific

REPL completions don't work. After hitting ENTER it is possible to continue typing 1 character at a time.

alexrudd2 commented 4 months ago

I will likely fix this with the pyright checks (if it isn't already fixed in dev)

alexrudd2 commented 4 months ago

The command completions work fine, it's only the argument completions that have the issue,

janiversen commented 4 months ago

REPL is moved, so closing.