search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.17k stars 891 forks source link

solve more mypy issues with datastore #2010

Closed alexrudd2 closed 4 months ago

alexrudd2 commented 4 months ago

This solves another 15 (counting with --check-untyped-defs)

janiversen commented 4 months ago

Now I see where you saw the problems....can you try to remove the ignore, and see if you get a problem with python 3.11 - 3.12...thanks in advance.

janiversen commented 4 months ago

I just checked your CI run, it looks a lot as if your dev is not updated (I changed CI a couple of days ago).

janiversen commented 4 months ago

Just to be sure, I have cleaned out all cache, and CI are running on dev as I write this....if CI turns green, I think the problem is somewhere else...agree ?

janiversen commented 4 months ago

dev is green after a new CI run, so I think the problem with "ignore" is an not updated dev branch ?

alexrudd2 commented 4 months ago

I think there was a cache problem. Some of the CI runners failed to even have Python installed