search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

Test if removal of pylint ignore works with CI. #2011

Closed janiversen closed 4 months ago

janiversen commented 4 months ago

If this turns green, then I have a problem with my venv, which complains heavily.

janiversen commented 4 months ago

@alexrudd2 my apologies ! my venv is somehow corrupted, sorry for the inconvenience.

What I do not understand, is how all CI dev runs have been successful since I added the ignores...I think there is a problem in what pylint or ruff actually controls, could that be ??

alexrudd2 commented 4 months ago

@alexrudd2 my apologies ! my venv is somehow corrupted, sorry for the inconvenience.

What I do not understand, is how all CI dev runs have been successful since I added the ignores...I think there is a problem in what pylint or ruff actually controls, could that be ??

This particular one is just a pylint warning, so it does not fail the run.