search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

Improve HTTP server type hints #2029

Closed alexrudd2 closed 4 months ago

alexrudd2 commented 4 months ago

This solves another 15 errors with mypy --checkuntyped defs pymodbus (and a few for pyright that mypy does not find).

It also looks like it fixes a real bug with time.sleep() not being called correctly. (The existing code attempts to call time.time() instead.)

alexrudd2 commented 4 months ago

Closing in favor of https://github.com/pymodbus-dev/pymodbus/pull/2035