search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.25k stars 922 forks source link

Reactive server no longer available with core pymodbus #2052

Closed dhoomakethu closed 7 months ago

dhoomakethu commented 7 months ago

Versions

Pymodbus Specific

Description

On the latest dev , Trying to run repl server results in error

Code and Logs

❯ pymodbus.server run
Traceback (most recent call last):
  File "/Users/sanjay/.virtualenvs/pymodbus/bin/pymodbus.server", line 5, in <module>
    from pymodbus_repl.server.main import app
  File ".virtualenvs/pymodbus/lib/python3.8/site-packages/pymodbus_repl/server/main.py", line 20, in <module>
    from pymodbus.server.reactive.default_config import DEFAULT_CONFIG
ModuleNotFoundError: No module named 'pymodbus.server.reactive.default_config'

cc @janiversen

dhoomakethu commented 7 months ago

@janiversen I was about to start a discussion to move reactive_server to repl repo, looks like you have already removed them. I will make the changes in repl repo. JFYI

dhoomakethu commented 7 months ago

Refer https://github.com/pymodbus-dev/pymodbus/pull/2038

janiversen commented 7 months ago

Thanks

janiversen commented 7 months ago

Assume this can be closed ?