pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

pypi do not like repl. #2069

Closed janiversen closed 4 months ago

janiversen commented 4 months ago

In order to get v3.6.5 uploaded, I had to modify pyproject.toml:

#repl = [
#   "pymodbus-repl@git+https://github.com/pymodbus-dev/repl"
#]

pypi do not like direct links (whatever that means).

dhoomakethu commented 4 months ago

Is the error while uploading the package or during the build?

janiversen commented 4 months ago

While doing "twine upload", strange enough "twine check" did not report any problems.

build works fine.

dhoomakethu commented 4 months ago

Will try to reproduce, thanks

dhoomakethu commented 4 months ago

Will be pushing version pymodbus. 3.7.0.dev0 to pypi for testing purpose. Will be yanked later. cc @janiversen

janiversen commented 4 months ago

Ok no problem.

dhoomakethu commented 4 months ago
pymodbus on  2069-pypi-do-not-like-repl [$!?] via 🐍 v3.8.13 (pymodbus)
❯ twine check dist/*
Checking dist/pymodbus-3.7.0.dev0-py3-none-any.whl: PASSED
Checking dist/pymodbus-3.7.0.dev0.tar.gz: PASSED

pymodbus on  2069-pypi-do-not-like-repl [$!?] via 🐍 v3.8.13 (pymodbus)
❯ twine upload -r pymodbus dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading pymodbus-3.7.0.dev0-py3-none-any.whl
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 206.3/206.3 kB • 00:01 • 260.1 kB/s
Uploading pymodbus-3.7.0.dev0.tar.gz
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 211.9/211.9 kB • 00:00 • 49.1 MB/s

View at:
https://pypi.org/project/pymodbus/3.7.0.dev0/