pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

Repair client close() (it overrides ModbusProtocol so intern= is needed, even though ugly). #2080

Closed janiversen closed 4 months ago

janiversen commented 4 months ago

The clients inherit directly from ModbusProtocol, which means the API close() overrides the internal (transport) close(), giving problems.

the intern= was only meant for internal usage, but is added to the client close() in order to have a disconnect work.

This is UGLY and should not be so, but it is a fast fix, a proper solution will come later.