search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 891 forks source link

Remove dead code from framer #2094

Closed alexrudd2 closed 3 months ago

alexrudd2 commented 3 months ago

get_expected_response_length was totally removed in https://github.com/pymodbus-dev/pymodbus/commit/9cf07243838c12563b2ad710efbb70fb1b0c0959#diff-126482fdc00ef924006c76c322c03c809c8b598b66f0af83ab9f5aade84a6a11L314-L323 and therefore this entire branch is useless.



janiversen commented 3 months ago

Please stop changing in framers and message (in message type changes etc are ok). At least these big changes that ruins my ongoing work.

You are changing work in progress, without really changing it...e.g. the to_do files are to remember test cases.

alexrudd2 commented 3 months ago

See https://github.com/pymodbus-dev/pymodbus/pull/2096.

We are very close to "throwing the switch" for more mypy checks. Merge your changes and I'll resolve the conflicts. I hope it will make the refactors more robust :)

janiversen commented 3 months ago

Done (sadly enough without a PR, due to a lapse in mind).

alexrudd2 commented 3 months ago

Superseded by 504af274d920fae5e859edc7d914ce5c03a15a75