search

pymodbus-dev / pymodbus

A full modbus protocol written in python
Other
2.16k stars 889 forks source link

call async datastore from modbus server execute flow #2144

Closed ilkka-ollakka closed 2 months ago

ilkka-ollakka commented 3 months ago

Take into use of async_getValues and async_setValues in modbus-server message handling, allowing datastore (mainly remote datastore) to use async flow.

Originally split from https://github.com/pymodbus-dev/pymodbus/pull/2127

ilkka-ollakka commented 3 months ago

Currently CI fails, as depending PR's are not yet in place. PR itself is currently edits from getValues -> await async_getValues and setValues -> await async_setValues to make it easier to review.

janiversen commented 2 months ago

A PR is independent, we do not merge/split PRs.

If a PR is depending on other PRs then please mark it as draft, so nobody wastes time.

janiversen commented 2 months ago

I have lost the overview...you have 3 open PR`s, is any of them ready to be merged (all comments resolved) ??

Seems you do not allow maintainers to update the PR, so I cannot rebase the 3 PRs, please do a rebase on the one where you want a final review.

ilkka-ollakka commented 2 months ago

I have lost the overview...you have 3 open PR`s, is any of them ready to be merged (all comments resolved) ??

This one is only one that depends on those 2 other PR's, to my understanding all comments have been reacted.

Seems you do not allow maintainers to update the PR, so I cannot rebase the 3 PRs, please do a rebase on the one where you want a final review.

All are now rebased

janiversen commented 2 months ago

Is this ready for review ?